Skip to content

linalg/x86_64: optimize softmax instruction scheduling with interleaved fmadd/vmaxps #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
czoli1976 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

linalg/x86_64: optimize softmax instruction scheduling with interleaved fmadd/vmaxps #2396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions linalg/src/x86_64_fma/softmax.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,10 @@ unsafe fn x86_64_fma_softmax2_fastcompact_f32_32n_run(buf: &mut [f32], max: f32)

vfmadd231ps ymm8, ymm4, ymm14
vfmadd231ps ymm9, ymm5, ymm14
vfmadd231ps ymm10, ymm6, ymm14
vfmadd231ps ymm11, ymm7, ymm14

vmaxps ymm8, ymm8, ymm12
vmaxps ymm9, ymm9, ymm12
vfmadd231ps ymm10, ymm6, ymm14
vfmadd231ps ymm11, ymm7, ymm14
vmaxps ymm10, ymm10, ymm12
vmaxps ymm11, ymm11, ymm12

Expand Down Expand Up @@ -189,11 +188,10 @@ unsafe fn x86_64_avx512_softmax2_fastcompact_f32_64n_run(buf: &mut [f32], max: f

vfmadd231ps zmm8, zmm4, zmm30
vfmadd231ps zmm9, zmm5, zmm30
vfmadd231ps zmm10, zmm6, zmm30
vfmadd231ps zmm11, zmm7, zmm30

vmaxps zmm8, zmm8, zmm28
vmaxps zmm9, zmm9, zmm28
vfmadd231ps zmm10, zmm6, zmm30
vfmadd231ps zmm11, zmm7, zmm30
vmaxps zmm10, zmm10, zmm28
vmaxps zmm11, zmm11, zmm28

Expand Down Expand Up @@ -327,12 +325,10 @@ unsafe fn x86_64_avx512_softmax2_fastcompact_f16_64n_run(
vmovaps zmm11, zmm31
vfmadd231ps zmm8, zmm4, zmm30
vfmadd231ps zmm9, zmm5, zmm30
vfmadd231ps zmm10, zmm6, zmm30
vfmadd231ps zmm11, zmm7, zmm30

// max(0, ...)
vmaxps zmm8, zmm8, zmm28
vmaxps zmm9, zmm9, zmm28
vfmadd231ps zmm10, zmm6, zmm30
vfmadd231ps zmm11, zmm7, zmm30
vmaxps zmm10, zmm10, zmm28
vmaxps zmm11, zmm11, zmm28

Expand Down