Skip to content

fix(helm): redact API key when echoing auth response in test-local.sh #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rguichard wants to merge 1 commit into from
Closed

fix(helm): redact API key when echoing auth response in test-local.sh #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion helm/charts/erpc/test-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,9 @@ if [ -n "${LABELS_SERVICE_API_KEY:-}" ] && [ "$LABELS_SERVICE_API_KEY" != "your-
echo "✅ Authentication with proper secret parameter works"
else
echo "⚠️ Authentication secret parameter didn't work as expected"
echo " Response: $auth_response_with_secret"
# Redact the API key in case the response (or a reflected error)
# echoes back the request URL containing the secret.
echo " Response: ${auth_response_with_secret//$LABELS_SERVICE_API_KEY/***REDACTED***}"
fi
else
echo "⚠️ Authentication might not be properly configured (no auth rejection detected)"
Expand Down
Loading