fix(helm): redact API key when echoing auth response in test-local.sh#106
Closed
rguichard wants to merge 1 commit into
Conversation
The auth test issues a request whose URL contains LABELS_SERVICE_API_KEY and, on unexpected failure, echoed the raw response. While the JSON-RPC body itself doesn't carry the secret, an error response can reflect the request URL (and thus the key). Mask the key in the printed output as defense-in-depth. Addresses Aikido finding on helm/charts/erpc/test-local.sh:195. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an Aikido finding on PR #90 (
helm/charts/erpc/test-local.sh:195).The auth test issues a request whose URL contains
LABELS_SERVICE_API_KEYand, on unexpected failure, echoed the raw response. While the JSON-RPC body itself doesn't carry the secret, an error response can reflect the request URL (and thus the key). The key is now masked in the printed output as defense-in-depth.🤖 Generated with Claude Code