Update mkdocs#1130
Merged
Merged
Conversation
drewnoakes
approved these changes
Jun 16, 2025
drewnoakes
left a comment
drewnoakes
left a comment
Member
There was a problem hiding this comment.
Thanks for bringing this back!
Member
|
Hopefully this gets things building again. The project page seems to be https://app.readthedocs.org/projects/netmq/ Will see if merging this kicks off a run, otherwise I'll try and log in there and see why not :) |
Member
|
It didn't run, and I don't have permissions on readthedocs.org for the NetMQ project. The current maintainers are @somdoron and @sachabarber. Are either of you able to add me as an admin there? Seems pretty easy. Just log in using GitHub and update it.
https://app.readthedocs.org/projects/netmq/ I suspect we need to update a web hook or some other action to connect the two. Looks like it hasn't run in nearly six years! |
Member
|
Filed #1133 to get the service working again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revived #1028 - Trying to give some love to this project as I use it a lot
I'd like to get the documentation back to up and running - I ran mkdocs locally, can confirm it was broken but now it "Works On My Machine"™️after fixing the mkdocs.yaml file.
It's unclear if there's something more to be done for readthedocs to pick up the changes, I'm not 100% familiar with how it's hooked up under the hood but the mkdocs part is all fixed!
With a bit of luck, this is all that's needed and merging this updates readthedocs