fix(db): fix batch_read_from_cache pairwise filter broken into cross product#3802
Merged
Merged
Conversation
…product Replace the unzip+eq_any approach with into_boxed() + or_filter() to ensure each (inbox_id, sequence_id) pair is matched individually instead of producing a cross-product (inbox_id IN list) AND (sequence_id IN list). Closes xmtp#3800
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3802 +/- ##
==========================================
- Coverage 84.54% 84.49% -0.05%
==========================================
Files 410 410
Lines 60716 60718 +2
==========================================
- Hits 51331 51305 -26
- Misses 9385 9413 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
insipx
approved these changes
Jul 2, 2026
Contributor
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3800
Note
Fix
batch_read_from_cachereturning cross-product matches instead of exact pairsThe previous implementation filtered by
inbox_id IN (...)ANDsequence_id IN (...)separately, causing a cross-product of all input inbox IDs and sequence IDs to be returned instead of only the exact(inbox_id, sequence_id)pairs requested.The fix in
association_state.rsreplaces the two-vector approach with iterativeor_filtercalls, each matching one exact(inbox_id, sequence_id)pair using a boxed query.Macroscope summarized 8e1128c.