Test DoChannelWindowAdjust overflow guard#1057
Open
ejohnstown wants to merge 1 commit into
Open
Conversation
- Add test_DoChannelWindowAdjust_overflow via new wolfSSH_TestDoChannelWindowAdjust wrapper. - Seed non-zero peer window, feed bytesToAdd = UINT32_MAX, assert WS_OVERFLOW_E with window unchanged. - Feed a fitting value, assert window advances. - Covers the guard so flipping or deleting it now fails. Issue: F-2874
Contributor
There was a problem hiding this comment.
Pull request overview
Adds internal unit test coverage for the existing overflow guard in DoChannelWindowAdjust (rejecting peer window adjustments that would wrap peerWindowSz past UINT32_MAX with WS_OVERFLOW_E). This fits into wolfSSH’s internal test strategy by exposing otherwise-static message handlers via wolfSSH_Test* wrappers and validating edge/boundary behavior.
Changes:
- Expose
DoChannelWindowAdjustto internal unit tests via a newwolfSSH_TestDoChannelWindowAdjust()wrapper. - Add a new unit test that validates overflow rejection, success on safe increments, and the exact boundary case.
- Register the new unit test in the unit test runner.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
wolfssh/internal.h |
Declares the new internal-test wrapper prototype behind WOLFSSH_TEST_INTERNAL. |
src/internal.c |
Implements wolfSSH_TestDoChannelWindowAdjust() to call the static handler. |
tests/unit.c |
Adds and runs test_DoChannelWindowAdjust_overflow() covering overflow + boundary behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit coverage for the overflow guard in
DoChannelWindowAdjust, which rejects a peer window adjustment that would wrappeerWindowSzpastUINT32_MAXwithWS_OVERFLOW_E. The guard existed but was untested. (F-2874)Test-only; no production behavior changes.