Skip to content

Implement visitX_Primitive where visitX_Declared exists#7813

Open
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:visit-x-primitive
Open

Implement visitX_Primitive where visitX_Declared exists#7813
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:visit-x-primitive

Conversation

@mernst

@mernst mernst commented Jul 8, 2026

Copy link
Copy Markdown
Member

In hopes of preventing more problems like #7806, this adds more overrides to DefaultTypeHierarchy.java.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3d41ebaf-979f-4f48-9e92-6eb04443c4aa

📥 Commits

Reviewing files that changed from the base of the PR and between e700d01 and 9b7ff5e.

📒 Files selected for processing (1)
  • framework/src/main/java/org/checkerframework/framework/type/DefaultTypeHierarchy.java

📝 Walkthrough

Walkthrough

This change adds two new visitor override methods to the DefaultTypeHierarchy class: visitArray_Primitive and visitUnion_Primitive. The former handles subtype checks between an array type and a primitive supertype by delegating to isPrimarySubtype. The latter handles subtype checks between a union type and a primitive supertype by delegating to visitUnion_Type. No existing logic is modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants