Skip to content

Use rootProject.createCheckTypeTask()#7805

Open
mernst wants to merge 2 commits into
typetools:masterfrom
mernst:gradle-root-project-create-check-type-task
Open

Use rootProject.createCheckTypeTask()#7805
mernst wants to merge 2 commits into
typetools:masterfrom
mernst:gradle-root-project-create-check-type-task

Conversation

@mernst

@mernst mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 29eab26b-782a-40d4-96de-10fea4eb3055

📥 Commits

Reviewing files that changed from the base of the PR and between 81c65b6 and 6279a28.

📒 Files selected for processing (1)
  • build.gradle

📝 Walkthrough

Walkthrough

This pull request reformats several createCheckTypeTask invocations in build.gradle into multi-line calls for the Formatter, Interning, Optional, Purity, Regex, ResourceLeak, and Signature checkers, without altering their arguments. Additionally, it removes the -AuseConservativeDefaultsForUncheckedCode=source compiler argument from the Nullness checker's task creation in the restricted-scope branch applicable to the framework, checker, and annotation-file-utilities projects, leaving only the -AskipUses=com.sun.* argument.

Changes

File Summary
build.gradle Reformatted multiple checker task creation calls to multi-line style; removed inline comments in Optional checker arguments; removed -AuseConservativeDefaultsForUncheckedCode=source argument from Nullness checker's restricted-scope task creation.

Related issues: None specified.

Related PRs: None specified.

Suggested labels: build, gradle

Suggested reviewers: None specified.


🐰 A gradle file gets a tidy sweep,
Multi-line calls now neat and deep,
One flag for Nullness slips away,
Skip-uses stands to save the day,
Hop along, the build compiles clean! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst

mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mernst mernst requested a review from smillst July 5, 2026 22:13
Comment thread build.gradle
// These pass and are run by the `typecheck` task.
// When you add one here, also update a dependsOn item for the "typecheck" task.
createCheckTypeTask(project.name, "Formatter",
rootProject.createCheckTypeTask(project.name, "Formatter",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the rootProject, so why is this needed?

@smillst smillst assigned mernst and unassigned smillst Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants