Skip to content

Use rootProject.libs#7804

Open
mernst wants to merge 2 commits into
typetools:masterfrom
mernst:gradle-root-project-libs
Open

Use rootProject.libs#7804
mernst wants to merge 2 commits into
typetools:masterfrom
mernst:gradle-root-project-libs

Conversation

@mernst

@mernst mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1623cd1f-a71b-4c7e-9997-27ced62d0b9c

📥 Commits

Reviewing files that changed from the base of the PR and between 81c65b6 and b37fb83.

📒 Files selected for processing (1)
  • build.gradle

📝 Walkthrough

Walkthrough

This change updates build.gradle to reference dependency versions through rootProject.libs instead of the local libs alias. The errorprone dependency and the annotatedGuava dependencies (error.prone.annotations and guava) are updated accordingly. No public or exported entities are affected.

Changes

File Change Summary
build.gradle Switched errorprone and annotatedGuava dependency declarations from local libs catalog to rootProject.libs catalog.

Sequence Diagram(s)

Not applicable — this change is limited to build configuration dependency references and does not involve a runtime flow.

Related Issues: Not specified in the provided information.

Related PRs: Not specified in the provided information.

Suggested labels: build, dependencies

Suggested reviewers: Not specified in the provided information.

Poem

A rabbit hops through gradle's maze,
Swapping libs for rootProject.libs, always precise,
Guava and errorprone, now aligned,
Version catalogs, neatly defined,
Three lines changed, the build still gleams.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernst

mernst commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@mernstcheckerframework

Copy link
Copy Markdown
Contributor

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@smillst smillst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T

Comment thread build.gradle

dependencies {
errorprone(libs.error.prone.core)
errorprone(rootProject.libs.error.prone.core)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build file is for the rootProject, so why is this needed? Also, there are many other uses of libs why aren't the changed?

@smillst smillst assigned mernst and unassigned smillst Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants