Added fix in viewnavigator.js that fixes back button issue on FireFox#42
Open
dfranc3373 wants to merge 4 commits into
Open
Added fix in viewnavigator.js that fixes back button issue on FireFox#42dfranc3373 wants to merge 4 commits into
dfranc3373 wants to merge 4 commits into
Conversation
Author
|
This also should fix the freezing glitch that some Android users have reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when using FireFox on the TV Listings example, that after you click the back button on at least 2 pages, it would crash with the error "viewDescriptor.animation = 'popEffect'". The error was caused by FireFox calling the script twice and popping the history object again setting it to null.
Fix was a if statement to check if the length of the array is not 1 before it pops.