Skip to content

Qa#57

Open
kriti2710 wants to merge 6 commits into
hotfixfrom
qa
Open

Qa#57
kriti2710 wants to merge 6 commits into
hotfixfrom
qa

Conversation

@kriti2710

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f5148a2cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/mcp.json
"TestDino": {
"command": "/opt/homebrew/bin/testdino-mcp",
"env": {
"TESTDINO_PAT": "tpu_d50a352ff1a128668ecaeba1da1026825eb314678cf47751d50c55503c89297e"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove committed TestDino PAT

This commit adds a live personal access token directly in source control, which exposes credentials to anyone who can read the repo/history and allows unauthorized access to the TestDino MCP service. Secrets must be loaded from environment/secret storage instead of being hardcoded in tracked files.

Useful? React with 👍 / 👎.

Comment thread tests/example.spec.js


/* ---------- STABLE TESTS (NO RANDOM FAILURES) ---------- */
test('Verify that user can update personal information', async () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore project tags so tests are actually selected

All tests in this file were switched to plain test(...) declarations, but playwright.config.js still uses project-level grep filters for @chromium, @firefox, @webkit, @android, @ios, and @api. With no matching tags, Playwright will select zero tests for every project and the pipeline can pass without executing coverage.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants