Add missing @Nullable type annotation to Iterator declaration#36910
Closed
subhramit wants to merge 1 commit into
Closed
Add missing @Nullable type annotation to Iterator declaration#36910subhramit wants to merge 1 commit into
@Nullable type annotation to Iterator declaration#36910subhramit wants to merge 1 commit into
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
@Nullable type annotation to field declaration@Nullable type annotation to Iterator declaration
Author
|
Closing as covered by #36850. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Nullaway had a warning highlighted in https://github.com/uber/NullAway/actions/runs/27324825986/job/80868514610.
On taking a look, it seemed to have merit.
In the covered code:
spring-framework/spring-web/src/main/java/org/springframework/web/util/UriComponents.java
Lines 348 to 352 in 0c60266
The varargs param is
@Nullable Object..., soArrays.asList(uriVariableValues)isList<@Nullable Object>and.iterator()isIterator<@Nullable Object>, but the field is declaredIterator<Object>.The PR aligns the type signatures by adding the missing
@Nullableannotation to the declaration.