Skip to content

feat(web): add isLanguageModelConfigured to service ping#1296

Merged
brendan-kellam merged 2 commits into
mainfrom
brendan/sou-1278-add-islanguagemodelconfigured-to-service-ping
Jun 10, 2026
Merged

feat(web): add isLanguageModelConfigured to service ping#1296
brendan-kellam merged 2 commits into
mainfrom
brendan/sou-1278-add-islanguagemodelconfigured-to-service-ping

Conversation

@brendan-kellam

@brendan-kellam brendan-kellam commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes SOU-1278

Adds isLanguageModelConfigured to the service ping payload, set to true when at least one language model is configured. Updates the mirrored lighthouse request schema (sourcebot-dev/lighthouse#16) and the Service Ping docs.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Service Ping now includes an isLanguageModelConfigured field to indicate whether at least one language model has been configured in your system.
  • Documentation

    • Updated Service Ping documentation with the new field and example payload.
    • Added guidelines ensuring Service Ping documentation remains synchronized with implementation updates.

Fixes SOU-1278

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

This comment has been minimized.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR adds an isLanguageModelConfigured boolean field to the Service Ping request payload. The schema is extended in types.ts, the implementation imports getConfiguredLanguageModels, computes whether any models are configured during syncWithLighthouse, and includes that flag in the ping request. User-facing docs and internal guidelines are updated accordingly.

Changes

Service Ping Language Model Configuration

Layer / File(s) Summary
Service Ping schema extension
packages/web/src/features/billing/types.ts
servicePingRequestSchema gains a required isLanguageModelConfigured: boolean field, which updates the inferred ServicePingRequest type.
Language model configuration telemetry
packages/web/src/features/billing/servicePing.ts
Implementation imports getConfiguredLanguageModels, awaits the result to compute a boolean flag during syncWithLighthouse, and includes isLanguageModelConfigured in the ServicePingRequest payload sent to client.ping.
Documentation and sync guidelines
CHANGELOG.md, docs/docs/misc/service-ping.mdx, packages/web/src/features/billing/CLAUDE.md
Changelog entry records the new field; Service Ping user docs are updated with the field in the reference table and example JSON; internal CLAUDE.md guidelines mandate syncing service-ping.mdx whenever servicePingRequestSchema changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • msukkari
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a new boolean field to the service ping payload.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch brendan/sou-1278-add-islanguagemodelconfigured-to-service-ping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mintlify

mintlify Bot commented Jun 10, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
sourcebot 🟢 Ready View Preview Jun 10, 2026, 1:52 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/web/src/features/billing/CLAUDE.md`:
- Around line 24-26: The fenced code block in CLAUDE.md that contains the path
"docs/docs/misc/service-ping.mdx" is missing a language hint and triggers
markdownlint MD040; update that fenced block by adding a language identifier
(e.g., "text") after the opening backticks so the block reads like ```text to
silence MD040 and keep the displayed content unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7af0de30-228b-4589-a151-44b906cb44e1

📥 Commits

Reviewing files that changed from the base of the PR and between 279bbb8 and 81e7fe5.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • docs/docs/misc/service-ping.mdx
  • packages/web/src/features/billing/CLAUDE.md
  • packages/web/src/features/billing/servicePing.ts
  • packages/web/src/features/billing/types.ts

Comment thread packages/web/src/features/billing/CLAUDE.md
@brendan-kellam brendan-kellam merged commit cfab0cf into main Jun 10, 2026
12 checks passed
@brendan-kellam brendan-kellam deleted the brendan/sou-1278-add-islanguagemodelconfigured-to-service-ping branch June 10, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant