block_quant: quantize einsum weights at either input slot#2428
Open
czoli1976 wants to merge 1 commit into
Open
block_quant: quantize einsum weights at either input slot#2428czoli1976 wants to merge 1 commit into
czoli1976 wants to merge 1 commit into
Conversation
The block_quant rewrite assumed the constant weight was always einsum input 0, so on imported ONNX `activation @ weight` matmuls (weight at input 1) it wired the block-quant tensor and the injected group axis to the wrong operands and tripped the EinSum rank check. Derive the weight and activation slots from the matched input and wire them accordingly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
block_quanttransform assumed the constant weight was always EinSum input 0 (tract's canonicalgmk,nkform), so on imported ONNXactivation @ weightmatmuls — where the weight is input 1 — it wired the block-quant tensor and the injected group axis to the wrong operands and tripped the EinSum input-rank check. This madeblock_quantunusable on essentially any imported transformer (a BERT/MiniLM encoder fails on the first attention matmul). The slot-0 assumption went unnoticed because the only coverage, thematmul_q40suite, constructs its weights at slot 0.Fix: derive the weight and activation slots from the matched input and wire them accordingly. Adds three regression tests covering both ONNX orientations (
mk,kn, batchedbmk,kn) and the canonicalmk,nk, each asserting numerical equivalence toX @ Q4_0(W).🍍