[Diffusion] Explicit MechanicalObject link#6073
Open
GaetanDesrues wants to merge 3 commits into
Open
Conversation
ADD: explicit link alternative to mecaObj
alxbilger
changed the title
fredroy
added
pr: status to review
fredroy
approved these changes
Apr 14, 2026
fredroy
left a comment
fredroy
left a comment
Contributor
There was a problem hiding this comment.
I see GaetanDesrues:v25.12 -> sofa-framework:v25.12
I think this PR should be merged into master, and might be backported to v25.12 later (or not)
Contributor
|
Hello, all ForceFields are SingleStateAccessor, which are member called |
hugtalbot
added
pr: status wip
Add PCGLinearSolver specialisations for assembled CompressedRowSparseMatrix
systems (CRS<SReal> and CRS<Mat3x3>), so the preconditioned conjugate
gradient can be used with an assembled linear system instead of only the
matrix-free GraphScattered pipeline. This makes it usable with
LinearSolverConstraintCorrection, which requires an assembled matrix.
For each CRS type, override:
* checkLinearSystem() -> create a MatrixLinearSystem<CRS,FV>
instead of the auto-created
PreconditionedMatrixFreeSystem<GraphScattered>.
* ensureRequiredLinearSystemType()-> accept the assembled MatrixLinearSystem.
* bwdInit() -> skip the PreconditionedMatrixFreeSystem linking.
* solve() -> drive the preconditioner directly on the
assembled matrix (precond->invert(M) once,
precond->solve(M, z, r) per iteration),
since a CRS preconditioner (e.g.
SSORPreconditioner) has no GraphScattered
setRHS/solveSystem/dispatch plumbing.
The stopping test is unchanged (preconditioned residual <r, M^-1 r> vs
tolerance * <b, b>), matching the GraphScattered implementation. Both new
templates are registered in the factory and explicitly instantiated.
bakpaul
added
pr: status to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an explicit link to the MechanicalObject instead of relying on tags
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if