Create configs when untracked repos found#2630
Open
cuba0001 wants to merge 1 commit into
Open
Conversation
cuba0001
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
July 25, 2026 15:39
cuba0001
force-pushed
the
untracked-repos
branch
from
July 25, 2026 16:23
cf667d1 to
9d2859e
Compare
Dry-run check results |
Kobzol
reviewed
Jul 25, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for the PR! I quickly glanced at the YAML file only, left one comment.
| env: | ||
| GITHUB_TOKEN: ${{ github.token }} # this one is generated by GHA | ||
| run: | | ||
| EXISTING_PULL_REQUEST_BRANCH=$( |
Member
There was a problem hiding this comment.
The branch name is a constant, same as in josh-sync. I don't think we need this lookup complexity.
- Run the
teamcommand and check if any TOML file was generated, according to its exit code - If yes, create the new branch, add the TOML files, commit it, and push to the branch
- If a PR does not exist at the moment, create it from that branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2582
According to the discussion in the previous #2611 it creates missing toml files. I added an exit code 2 to signal that untracked repos are found and configs are created, because this is the simplest way for the workflow to handle it. This still keeps code 1 for unexpected errors. When code 2 happens, the workflow checks if any PR exists, like it's done in josh-sync. Depending on it, the job either creates a new branch or switches to an existing one and runs sync-team. Thereby, previously created toml files won't be duplicated in the existing PR scenario.