Skip to content

chore: migrate linting to rslint and prettier#25

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier
Apr 28, 2026
Merged

chore: migrate linting to rslint and prettier#25
chenjiahan merged 1 commit into
mainfrom
chenjiahan/migrate-rslint-prettier

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR migrates the repository linting and formatting setup from Biome to the Rslint + Prettier workflow used by the rsbuild plugin template. It adds Rslint/Prettier configs and VS Code recommendations/settings, updates the lint scripts and pre-commit hook, and keeps the existing explicit-any allowance while cleaning up a few expressions required by Rslint recommended rules.

Copilot AI review requested due to automatic review settings April 28, 2026 11:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe4db278c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the repo’s linting/formatting workflow from Biome to Rslint + Prettier, aligning with the rsbuild plugin template and updating related editor/tooling setup.

Changes:

  • Replace Biome with @rslint/core + prettier, adding corresponding config files.
  • Update package.json scripts and the pre-commit hook to run the new lint/format commands.
  • Minor refactors to satisfy recommended lint rules and reformat docs/editor settings.

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils.ts Simplifies temp dir resolution logic (return early / explicit null on failure).
src/normalize.ts Adjusts callback params/formatting to satisfy lint rules.
src/matchers.ts Replaces short-circuit expressions with explicit if blocks for lint compliance.
rslint.config.ts Adds Rslint recommended TS config and rule override for explicit any.
package.json Updates scripts and pre-commit hook to use Rslint + Prettier.
pnpm-lock.yaml Removes Biome/nano-staged; adds Rslint/Prettier dependency graph.
biome.json Removes Biome configuration.
README.md Reformatting of the options table.
.vscode/settings.json Adds Prettier as the default formatter in VS Code.
.vscode/extensions.json Recommends Rslint + Prettier VS Code extensions.
.prettierrc Adds Prettier config (singleQuote).
.prettierignore Adds initial ignore list for Prettier runs.
.gitignore Allows committing .vscode/settings.json.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment thread .prettierignore
@chenjiahan chenjiahan merged commit 80f2018 into main Apr 28, 2026
9 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/migrate-rslint-prettier branch April 28, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants