chore: migrate linting to rslint and prettier#25
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe4db278c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Migrates the repo’s linting/formatting workflow from Biome to Rslint + Prettier, aligning with the rsbuild plugin template and updating related editor/tooling setup.
Changes:
- Replace Biome with
@rslint/core+prettier, adding corresponding config files. - Update
package.jsonscripts and the pre-commit hook to run the new lint/format commands. - Minor refactors to satisfy recommended lint rules and reformat docs/editor settings.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils.ts |
Simplifies temp dir resolution logic (return early / explicit null on failure). |
src/normalize.ts |
Adjusts callback params/formatting to satisfy lint rules. |
src/matchers.ts |
Replaces short-circuit expressions with explicit if blocks for lint compliance. |
rslint.config.ts |
Adds Rslint recommended TS config and rule override for explicit any. |
package.json |
Updates scripts and pre-commit hook to use Rslint + Prettier. |
pnpm-lock.yaml |
Removes Biome/nano-staged; adds Rslint/Prettier dependency graph. |
biome.json |
Removes Biome configuration. |
README.md |
Reformatting of the options table. |
.vscode/settings.json |
Adds Prettier as the default formatter in VS Code. |
.vscode/extensions.json |
Recommends Rslint + Prettier VS Code extensions. |
.prettierrc |
Adds Prettier config (singleQuote). |
.prettierignore |
Adds initial ignore list for Prettier runs. |
.gitignore |
Allows committing .vscode/settings.json. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This PR migrates the repository linting and formatting setup from Biome to the Rslint + Prettier workflow used by the rsbuild plugin template. It adds Rslint/Prettier configs and VS Code recommendations/settings, updates the lint scripts and pre-commit hook, and keeps the existing explicit-any allowance while cleaning up a few expressions required by Rslint recommended rules.