Skip to content

fix(audio): improve error handling for aborted audio streams #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yooudeek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(audio): improve error handling for aborted audio streams #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 46 additions & 5 deletions web/src/services/AudioService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,20 @@ export class AudioService {
lang_code: document.getElementById('lang-select').value || undefined
}),
signal: this.controller.signal
}).catch(error => {
// Handle abort errors gracefully
if (error.name === 'AbortError') {
console.log('Audio stream request aborted');
return null;
}
throw error;
});

// If request was aborted, return early
if (!response) {
return null;
}

console.log('AudioService: Got response', {
status: response.status,
headers: Object.fromEntries(response.headers.entries())
Expand Down Expand Up @@ -147,9 +159,23 @@ export class AudioService {
this.audio.src = this.objectUrl;
this.audio.load();

this.audio.addEventListener('error', () => {
console.error('Audio error (block mode):', this.audio?.error);
this.dispatchEvent('playbackUnavailable');
this.audio.addEventListener('error', (event) => {
const audioElement = event.target;
const errorCode = audioElement?.error?.code;
const errorMessage = audioElement?.error?.message || 'Unknown audio error';

console.error('Audio error (block mode):', {
code: errorCode,
message: errorMessage,
src: audioElement?.src,
networkState: audioElement?.networkState,
readyState: audioElement?.readyState
});

// Don't dispatch playbackUnavailable for abort errors
if (errorCode !== MediaError.MEDIA_ERR_ABORTED) {
this.dispatchEvent('playbackUnavailable');
}
});

this.audio.addEventListener('ended', () => {
Expand Down Expand Up @@ -182,8 +208,23 @@ export class AudioService {
this.objectUrl = URL.createObjectURL(this.mediaSource);
this.audio.src = this.objectUrl;

this.audio.addEventListener('error', () => {
console.error('Audio error:', this.audio?.error);
this.audio.addEventListener('error', (event) => {
const audioElement = event.target;
const errorCode = audioElement?.error?.code;
const errorMessage = audioElement?.error?.message || 'Unknown audio error';

console.error('Audio error:', {
code: errorCode,
message: errorMessage,
src: audioElement?.src,
networkState: audioElement?.networkState,
readyState: audioElement?.readyState
});

// Don't dispatch playbackUnavailable for abort errors
if (errorCode !== MediaError.MEDIA_ERR_ABORTED) {
this.dispatchEvent('playbackUnavailable');
}
});

this.audio.addEventListener('ended', () => {
Expand Down