Add CT source observability and retry attribution#9
Open
auspexlabs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the earlier PR on this. I closed the first attempt because it was too broad; this is the smaller focused patch after letting the fork bake in live operation longer.
This makes the CT source identity already present in log-list discovery visible in Prometheus metrics, while preserving the existing human
loglabels.The current code already parses
log_idfrom RFC6962 and tiled/static CT catalog entries and dedupes discovered logs by that identity. This patch adds a stable metrics join key for that same source identity:log: existing human-readable label, preserved for compatibilitysource_id: stable machine-oriented label:ctlog:<log_id>when a CT log ID is availableurl:<normalized_url>for local/id-less custom sourcesThis avoids replacing existing
logselectors while still making mixed RFC6962/static-CT behavior easier to inspect by source.Changes:
certstream_ct_runtime_log_infologlabels and addsource_idlog_typelog+source_idValidation:
cargo testgit diff --check