Add configurable static CT tail start overlap#10
Open
auspexlabs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the earlier PR on this. I closed the first attempt because it was premature; this is the smaller focused patch after letting the fork bake in live operation longer.
This makes the fresh-start overlap for static CT watchers configurable while preserving the current default behavior.
Today a new static CT watcher starts at
tree_size - 256. This keeps256as the default, but exposes it asct_log.start_overlap_leaveswith an env override for operators that want a wider or narrower tail window.Changes:
ct_log.start_overlap_leavesCERTSTREAM_CT_LOG_START_OVERLAP_LEAVES256behavior as the defaultValidation:
cargo testgit diff --check