Fix ios trim#1
Conversation
FrikkieSnyman
commented
May 8, 2020
FrikkieSnyman
commented
- Merge original repo master
- Make use of .mov instead of .mp4
* Adding the possibility to trim a remote file * Updating README to include some comment about trimmming remote files
RalfNieuwenhuizen
left a comment
RalfNieuwenhuizen
left a comment
There was a problem hiding this comment.
Magic! What does it fix exactly?
|
On iOS, when you take a "quick capture" video on iPhone 11 and up, the trim method throws an error that this mediatype is not supported. Someone using the Vimeo library ran into the same issue, and they suggested this fix: With this PR, the video can be trimmed, but the thumbnail of the trimmed video's orientation is wrong |
So this is not perfect yet, you mean? |
|
Well this PR is, but grabbing the thumbnail is not. It's got something to do with how .mov stores the meta describing the orientation of the video compared to how .mp4 does it. So the way we grab the thumbnail basically assumes it's an mp4 and is therefor looking at the wrong place to get the correct orientation of the video 🤷 |
|
@FrikkieSnyman will this be irrelevant after falafelraptor stuff? |
|
@RalfNieuwenhuizen I hope so! Going to test if the falafelraptor stuff fixed ios today! |
|
@RalfNieuwenhuizen No, it doesn't seem like their stuff fixed it :/ |
3 participants
