Skip to content

QLI2.0 | Shikra SoC boot enablement: LLCC, EDAC, and TLMM GPIO reserved ranges#733

Open
apateriy-qcom wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
apateriy-qcom:6.18.y-boot
Open

QLI2.0 | Shikra SoC boot enablement: LLCC, EDAC, and TLMM GPIO reserved ranges#733
apateriy-qcom wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
apateriy-qcom:6.18.y-boot

Conversation

@apateriy-qcom

Copy link
Copy Markdown

Summary

This series adds boot-related enablement for the Shikra SoC on the 6.18.y branch, covering Last Level Cache (LLCC)
configuration, optional EDAC IRQ setup, and TLMM GPIO reservations across the Shikra EVK variants.

Commits

  1. soc: qcom: llcc: Add configuration data for Shikra SoC
    Adds the Last Level Cache table and configs for the Shikra SoC.
  2. EDAC/qcom: Make irq configuration optional
    On Shikra, IRQ configuration is already handled in firmware (DSF / DDR System Firmware), so the driver's IRQ setup is made
    optional to avoid conflicting/duplicate configuration.
  3. arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm
    Adds the gpio-reserved-ranges property to the tlmm node for all three Shikra EVK variants (CQM, CQS, IQS) to mark GPIOs.

@apateriy-qcom apateriy-qcom requested review from a team, quic-tingweiz, rrnayak and yijiyang June 17, 2026 18:21
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Komal-Bajaj and others added 3 commits June 18, 2026 00:00
Add Last Level Cache table and configs for the Shikra SoC.

Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
On Shikra irq configuration is already done in firmware
(in DSF or 'DDR System Firmware').

Change-Id: Idedb3ba1435cd54df8dd32c0882203b8b7e963d7
Signed-off-by: Faiyaz Mohammed <faiyazm@qti.qualcomm.com>
Add gpio-reserved-ranges property to the tlmm node for all three
Shikra EVK variants (CQM, CQS, IQS) to mark GPIOs used by the
SoC internally and not available for general use.

Signed-off-by: Anurag Pateriya <apateriy@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #733 — validate-patch

PR: #733

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: No — no Link: tags found in any commit message
  2. Lore link matches PR commits: N/A — no lore links to compare against
  3. Upstream patch status: Unknown — no evidence of upstream submission found via lore.kernel.org search
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Recommendation: Remove Change-Id from patch 2/3 before merge. Clarify whether these are vendor-only patches (add QCLINUX: prefix) or if upstream submission is planned (add Link: tags when available).

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #733 - Shikra SoC support (LLCC, EDAC, DTS)
Upstream commit: N/A (no lore links found)
Verdict: ⚠️ PARTIAL


Patch 1/3: soc: qcom: llcc: Add configuration data for Shikra SoC

Commit Message

Check Status Note
Subject matches upstream N/A No upstream reference found
Body preserves rationale ⚠️ Minimal description; lacks hardware details
Fixes tag present/correct N/A Not a fix
Authorship preserved Komal Bajaj komal.bajaj@oss.qualcomm.com
Backport note (if applicable) N/A New feature, not a backport

Diff

File Status Notes
drivers/soc/qcom/llcc-qcom.c Clean addition following existing patterns

Issues

  • Commit message is very terse; typical upstream submissions include more context about the SoC and cache configuration
  • No Link: tag to upstream submission

Patch 2/3: EDAC/qcom: Make irq configuration optional

Commit Message

Check Status Note
Subject matches upstream N/A No upstream reference found
Body preserves rationale ⚠️ Explains why but lacks detail on implementation
Fixes tag present/correct N/A Not a fix
Authorship preserved Faiyaz Mohammed faiyazm@qti.qualcomm.com
Backport note (if applicable) N/A New feature, not a backport

Diff

File Status Notes
drivers/soc/qcom/llcc-qcom.c Single-line addition, clean

Issues

  • Change-Id: Idedb3ba1435cd54df8dd32c0882203b8b7e963d7 — Gerrit artifact must be removed before upstream submission
  • Commit message could explain what irq_configured flag does and why firmware handles IRQ setup on Shikra
  • No Link: tag to upstream submission

Patch 3/3: arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm

Commit Message

Check Status Note
Subject matches upstream N/A No upstream reference found
Body preserves rationale Clear explanation of purpose
Fixes tag present/correct N/A Not a fix
Authorship preserved Anurag Pateriya apateriy@qti.qualcomm.com
Backport note (if applicable) N/A New feature, not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts Identical reserved ranges across all variants
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts Identical reserved ranges across all variants
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts Identical reserved ranges across all variants

Issues

  • None for this patch

Issues

Patch 2/3 — Critical:

  • Change-Id tag must be removed — this is a Gerrit artifact that should never appear in upstream kernel commits or production branches

All patches — Minor:

  • No Link: tags pointing to lore.kernel.org submissions
  • Commit messages are minimal compared to typical upstream standards
  • No indication whether these patches have been posted upstream or are vendor-only

Verdict

Patch 2/3 must be amended to remove the Change-Id tag before merge. Patches 1 and 3 are technically correct but lack upstream references. If these are vendor-only patches, they should be prefixed with QCLINUX: or similar to indicate they are not intended for upstream.


Final Summary

  1. Lore link present: No — no Link: tags found in any commit message
  2. Lore link matches PR commits: N/A — no lore links to compare against
  3. Upstream patch status: Unknown — no evidence of upstream submission found via lore.kernel.org search
  4. PR present in qcom-next: Not checked — no kernel tree access per constraints

Recommendation: Remove Change-Id from patch 2/3 before merge. Clarify whether these are vendor-only patches (add QCLINUX: prefix) or if upstream submission is planned (add Link: tags when available).

@qlijarvis

Copy link
Copy Markdown

PR #733 — checker-log-analyzer

PR: #733
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27711376388

Checker Result Summary
Checker Result Summary
checkpatch Gerrit Change-Id found in commit 2/3
dt-binding-check No DT binding changes
dtb-check All DTB validations passed
sparse-check No sparse warnings
check-uapi-headers No UAPI header changes
check-patch-compliance Missing UPSTREAM:/FROMLIST: prefix on all 3 commits
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check ⏭️ Not applicable for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #733 - Add Shikra SoC support (LLCC, EDAC, DTS)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27711376388

Checker Result Summary
checkpatch Gerrit Change-Id found in commit 2/3
dt-binding-check No DT binding changes
dtb-check All DTB validations passed
sparse-check No sparse warnings
check-uapi-headers No UAPI header changes
check-patch-compliance Missing UPSTREAM:/FROMLIST: prefix on all 3 commits
tag-check N/A Not applicable for qcom-6.18.y branch
qcom-next-check ⏭️ Not applicable for qcom-6.18.y branch

❌ checkpatch

Root cause: Commit 2/3 (0d4f03a767db) contains a Gerrit Change-Id tag that must be removed before upstream submission.

Failure details:

Commit 0d4f03a767db ("EDAC/qcom: Make irq configuration optional")
------------------------------------------------------------------
ERROR: Remove Gerrit Change-Id's before submitting upstream
#9: 
Change-Id: Idedb3ba1435cd54df8dd32c0882203b8b7e963d7

0d4f03a767db1cfee908d1458e7b0e950518fcf9 total: 1 errors, 0 warnings, 0 checks, 7 lines checked

Fix: Remove the Change-Id: Idedb3ba1435cd54df8dd32c0882203b8b7e963d7 line from the commit message of commit 2/3. Use git rebase -i to edit the commit message:

git rebase -i HEAD~3
# Mark commit 2/3 for 'reword' or 'edit'
# Remove the Change-Id line from the commit message
# Save and continue the rebase

Reproduce locally:

./scripts/checkpatch.pl --strict --git HEAD~2..HEAD~1

❌ check-patch-compliance

Root cause: All three commits lack the required UPSTREAM: or FROMLIST: prefix in their subject lines, which is mandatory for patches targeting qcom-6.18.y branch.

Failure details:

Checking commit: soc: qcom: llcc: Add configuration data for Shikra SoC
Commit summary does not start with a required prefix

Checking commit: EDAC/qcom: Make irq configuration optional
Commit summary does not start with a required prefix

Checking commit: arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm
Commit summary does not start with a required prefix

Fix: Add the appropriate prefix to each commit subject:

  • If these patches are already merged upstream (mainline or stable), use UPSTREAM: prefix
  • If these patches are posted to a mailing list but not yet merged, use FROMLIST: prefix
  • If these are downstream-only patches, they may not be suitable for qcom-6.18.y

Example for FROMLIST patches:

git rebase -i HEAD~3
# Mark all commits for 'reword'
# Change subjects to:
# FROMLIST: soc: qcom: llcc: Add configuration data for Shikra SoC
# FROMLIST: EDAC/qcom: Make irq configuration optional
# FROMLIST: arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm

Reproduce locally:

# Check if commits have required prefix
git log --oneline HEAD~3..HEAD
# Each commit should start with UPSTREAM: or FROMLIST:

Verdict

2 blockers must be fixed before merge:

  1. checkpatch failure: Remove Gerrit Change-Id from commit 2/3
  2. check-patch-compliance failure: Add UPSTREAM: or FROMLIST: prefix to all 3 commit subjects

All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed successfully. Once the Change-Id is removed and proper prefixes are added, this PR will be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants