media: qcom: iris: fix enum_frameintervals to support non-integer framerates#731
Open
gouravk-qualcomm wants to merge 1 commit into
Open
media: qcom: iris: fix enum_frameintervals to support non-integer framerates#731gouravk-qualcomm wants to merge 1 commit into
gouravk-qualcomm wants to merge 1 commit into
Conversation
gouravk-qualcomm
requested review from
a team,
knaveen-qc,
quic-kaushalk and
shashim-quic
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4515234 on any of the following entities: Entities:
CR: 4515234 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
…teger framerates iris_enum_frameintervals() had min/max swapped in the stepwise frame interval structure. This caused GStreamer to enumerate a discrete list of framerates (480/n), which excluded non-integer values like 29.97 fps (30000/1001), resulting in caps negotiation failure. Fix by swapping min and max denominators so GStreamer's enumeration loop exits immediately, leaving the framerate unconstrained in caps and allowing any framerate to negotiate successfully. Signed-off-by: Gourav Kumar <gouravk@qti.qualcomm.com>
gouravk-qualcomm
force-pushed
the
frameinterval-fix
branch
from
0175a1d to
91c622f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding fails with "internal data stream error" for input videos with
non-integer framerates (e.g., 29.97 fps / 30000/1001)
video driver returned a STEPWISE range with min=1/fps and max=1/1.
GStreamer enumerated this as a discrete list of framerates (480/1,
240/1, ..., 30/1, ..., 1/1). Since 29.97 fps is not expressible as 480/n for
any integer n, caps negotiation failed.
Swap min and max denominators (min=1/1, max=1/fps). GStreamer's
loop condition fails immediately, no discrete list is built, and the
framerate is left unconstrained, accepting any framerate including
29.97 fps.
CRs-Fixed: 4515234