Switch to pyrepl#3453
Open
A5rocks wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3453 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19417 19438 +21
Branches 1317 1307 -10
===============================================
+ Hits 19417 19438 +21
🚀 New features to boost your workflow:
|
6d670a3 to
0f95c88
Compare
Contributor
Author
|
I took the opportunity to run the REPL input loop in the main thread too, since it seemed easy enough. One downside is that, since the version of pyrepl on PyPI has a bug w/r/t non-blocking operation, CPython w/ 3.12 or less will have a worse experience in the REPL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up some code and makes Linux support work even on some systems configured without TIOCSTI. Fixes #3007, closes #3306.
I didn't try this out on Windows, and pyrepl simply cannot be tested easily in CI on Windows, so that may be broken. Please try this out!