Skip to content

i18n(ja): Revert keywords.md keyword list to English (#22977 follow-up)#23004

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-keywords-ja-release-8.5
Open

i18n(ja): Revert keywords.md keyword list to English (#22977 follow-up)#23004
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-keywords-ja-release-8.5

Conversation

@yahonda
Copy link
Copy Markdown
Member

@yahonda yahonda commented Jun 4, 2026

This PR re-applies the fix from #22977 which was overwritten by the automated translation update (commit 6a9f17f).

Changes

Reverts the keyword list in keywords.md from Japanese translations back to English, matching the original #22977 fix.

The SQL keywords themselves (e.g., SELECT, UPDATE, DELETE) are universal identifiers and should remain in English even in Japanese documentation.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the keywords.md file by reverting the Japanese translations of SQL keywords back to their standard English uppercase representations (e.g., converting 'アカウント' to 'ACCOUNT') and making minor Japanese phrasing improvements in the introductory text. Feedback was provided to refine a sentence on line 12 to ensure a more natural Japanese structure, avoiding an unnatural trailing colon and backticks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread keywords.md Outdated
@yahonda yahonda force-pushed the fix-keywords-ja-release-8.5 branch from cfdada1 to c0d5fec Compare June 4, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant