Fix GH-17976: CRLF injection via from and user_agent in HTTP wrapper#21658
Open
iliaal wants to merge 1 commit into
Open
Fix GH-17976: CRLF injection via from and user_agent in HTTP wrapper#21658iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The from and user_agent INI settings and the user_agent stream context option were written into HTTP request headers without stripping CR/LF characters, allowing header injection. Truncate at the first \r or \n and emit E_WARNING. Closes phpGH-17976
iliaal
force-pushed
the
fix/gh-17976-crlf-injection-http-wrapper
branch
from
76e5410 to
02175be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fopen HTTP wrapper writes
fromanduser_agentINI settings (and theuser_agentstream context option) into HTTP request headers without stripping CR/LF characters, allowing header injection.Truncate at the first
\ror\nand emitE_WARNING.Fixes #17976