fix(auth): revocable access tokens + rate limiting + auth on oauth introspect/revoke (C3/H3/M4/OM1)#61
Open
PenguinzTech wants to merge 1 commit into
Conversation
…uth introspect/revoke (C3/H3/M4/OM1) - C3: access tokens now carry a jti; a revoked_access_tokens blocklist is checked in auth_required, so /logout and /oauth/revoke actually invalidate the current access token (previously only refresh tokens were revoked). Blocklist self-prunes on expiry. - H3/M4: real rate limiter (app/rate_limiter.py) — Redis-backed when REDIS_ENABLED else in-memory, respects RATE_LIMIT_ENABLED. Applied to /auth/login, /auth/register, /oauth/token; returns 429 on limit. - OM1: /oauth/introspect and /oauth/revoke now require authentication; introspect returns active:false for revoked tokens or deactivated (is_active=false) users. Tests: revocation, rate-limit 429, oauth-security + comprehensive rate_limiter tests. Suite: 441 passed, 1 skipped, 90.82% coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @PenguinzTech, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes (Track A4)
Stacked on #58 (base =
fix/tenant-team-isolation). Targetsrelease/v0.1.x.jti; arevoked_access_tokensblocklist is checked inauth_required, so/logoutand/oauth/revokeactually invalidate the current access token (previously only refresh tokens were revoked). Blocklist self-prunes on expiry.app/rate_limiter.py): Redis-backed whenREDIS_ENABLEDelse in-memory, respectsRATE_LIMIT_ENABLED. Applied to/auth/login,/auth/register,/oauth/token; returns 429./oauth/introspectand/oauth/revokenow require authentication; introspect returnsactive:falsefor revoked tokens or deactivated users.Uses the existing
redis==5.2.0dep; requirements recompiled with uv (house-preferred).Tests
Revocation, 429 rate-limit, oauth-security + comprehensive rate_limiter tests. Suite: 441 passed, 1 skipped, 90.82% coverage.
🤖 Generated with Claude Code