fix(core): coerce unknown material.preset to 'custom' (Sentry MONOREPO-EDITOR-DB)#400
Open
anton-pascal wants to merge 1 commit into
Open
fix(core): coerce unknown material.preset to 'custom' (Sentry MONOREPO-EDITOR-DB)#400anton-pascal wants to merge 1 commit into
anton-pascal wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Production editor crashes with an unhandled
ZodErrorduring slab boundary edits (Sentry MONOREPO-EDITOR-DB, issue id7543527892):Stack:
polygon-editor.tsx→ slab/boundary-editorhandlePolygonChange→use-sceneupdateNode→SlabNode.parse.This happens when node data carries a
material.presetvalue outside theMaterialPresetenum — typically legacy, imported, or AI-generated scenes (e.g."stone").Fix
In
MaterialSchema, change:to:
Unknown preset values are now coerced to
'custom'instead of throwing, making loading/updating tolerant of bad data. The exportedMaterialPresetenum itself stays strict, so all other consumers keep exact enum validation.resolveMaterialalready falls back toDEFAULT_MATERIALS.custommerged withmaterial.propertiesfor'custom', so coerced materials render with whatever explicit properties the node carries.Verified
undefinedhandling: missing/undefinedpreset still parses toundefined(zod v4.catch()before.optional()does not swallowundefined).Tests
New
packages/core/src/schema/material.test.ts:'stone') coerces to'custom''custom'undefinedpreset staysundefinedbun test src/schema/→ 50 pass, 0 fail;tsc --buildclean; biome check clean.