process: fix finalization cleanup ref tracking#64087
Open
trivikr wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
needs-ci
Renegade334
reviewed
Jun 23, 2026
trivikr
force-pushed
the
lib-internal-process-finalization
branch
4 times, most recently
from
35a57c9 to
ce00f56
Compare
Member
|
I would just squash the commits, there's no need to keep the splice change in the commit log if we're immediately removing it. Otherwise LGTM! |
Use SafeSet collections for finalization refs so insertion, removal, and emptiness checks match the identity-based tracking model. This also fixes cleanup removal for collected refs. Previously cleanup used the ref index as the splice delete count, which could remove later live refs when the collected ref was not first. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
lib-internal-process-finalization
branch
from
ce00f56 to
4ff51d8
Compare
Member
Author
|
@Renegade334 Squashed into a single commit |
trivikr
changed the title
Renegade334
approved these changes
Jun 24, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64086
Fix
process.finalizationcleanup so collecting one registeredobject does not accidentally remove later live finalization refs.
Finalization refs are now tracked with
SafeSetcollections insteadof arrays, which matches the identity-based add/remove behavior
used by registration, cleanup, and unregister paths.
Assisted-by: openai:gpt-5.5