chore(parsing): better use of code spans#840
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
Reviewed by Cursor Bugbot for commit f394719. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f394719. Configure here.
| if (inner === null) { | ||
| return null; | ||
| } | ||
| return `<code><${inner}></code>`; |
There was a problem hiding this comment.
Type output breaks typed list parsing
High Severity
Wrapping resolved types as <code><…></code> with inner markdown links like [string](url) no longer matches what downstream code expects: link nodes whose child is inlineCode starting with <. Typed parameter lists then fail strongly-typed detection and extractTypeAnnotations leaves type unset, so signature tables and legacy HTML type-link handling break.
Reviewed by Cursor Bugbot for commit f394719. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
==========================================
+ Coverage 82.80% 84.60% +1.80%
==========================================
Files 171 176 +5
Lines 14904 15813 +909
Branches 1305 1412 +107
==========================================
+ Hits 12341 13379 +1038
+ Misses 2555 2424 -131
- Partials 8 10 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|


Fixes #839 by only outputting the code spans on the outermost resolution
Note: This changes the output slightly, from
<MyType>to<MyType>