-
Notifications
You must be signed in to change notification settings - Fork 48
feat(cli): add progress bar to generation pipeline #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shivxmsharma
wants to merge
8
commits into
nodejs:main
Choose a base branch
from
shivxmsharma:feat/cli-progress-bar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
57a244e
feat(cli): add progress bar to generation pipeline
shivxmsharma 806c0bf
Update src/utils/configuration/types.d.ts
shivxmsharma 87b8843
Update src/generators.mjs
shivxmsharma b74b39e
refactor: address review feedback - use PassThrough stream, remove op…
shivxmsharma 5f287ef
meta: update type map
create-or-update-pull-request 22de64f
Merge pull request #1 from shivxmsharma/chore/update-types
shivxmsharma 5189ed4
Merge branch 'nodejs:main' into main
shivxmsharma 77a37e7
Merge remote-tracking branch 'origin/main' into feat/cli-progress-bar
shivxmsharma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| 'use strict'; | ||
|
|
||
| import { PassThrough } from 'node:stream'; | ||
|
|
||
| import { SingleBar, Presets } from 'cli-progress'; | ||
|
|
||
| /** | ||
| * Creates a progress bar for the generation pipeline. | ||
| * Writes to stderr to avoid conflicts with the logger (stdout). | ||
| * When disabled or stderr is not a TTY (e.g. CI), output is sent | ||
| * to a PassThrough stream (silently discarded). | ||
| * | ||
| * @param {object} [options] | ||
| * @param {boolean} [options.enabled=true] Whether to render the progress bar | ||
| * @returns {SingleBar} | ||
| */ | ||
| const createProgressBar = ({ enabled = true } = {}) => { | ||
| const shouldEnable = enabled && process.stderr.isTTY; | ||
|
|
||
| return new SingleBar( | ||
|
shivxmsharma marked this conversation as resolved.
|
||
| { | ||
| stream: shouldEnable ? process.stderr : new PassThrough(), | ||
| format: ' {phase} [{bar}] {percentage}% | {value}/{total}', | ||
| hideCursor: true, | ||
| clearOnComplete: false, | ||
| }, | ||
| Presets.shades_grey | ||
| ); | ||
| }; | ||
|
|
||
| export default createProgressBar; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.