Many small changes#2
Open
kashyapp wants to merge 2 commits into
Open
Conversation
1. Use nanos until the end 2. Reuse executor service, resize when needed 3. Cycle through input file in Step command 4. Use ByteStreams.copy in Fist 5. Embed $JAVA_OPTS placeholder into the executable jar 6. Fix request rate calculations 7. Add some more basic stats to Step's report Also, split construction and invocation of Fight from Step Makes sense since we're spawning all the threads of the threadpool from within the constructor.
Author
|
ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, split construction and invocation of Fight from Step
Makes sense since we're spawning all the threads of the threadpool from
within the constructor.