fix(office): exclude external storage from the "Mine" filter#48
Open
moodyjmz wants to merge 1 commit into
Open
fix(office): exclude external storage from the "Mine" filter#48moodyjmz wants to merge 1 commit into
moodyjmz wants to merge 1 commit into
Conversation
Most storage backends' getOwner() defaults to whoever is currently browsing when there's no single real owner, which is the normal case for external storage. The "Mine" filter only excluded group/shared mount-types, so files on a shared external storage mount showed up as "Mine" for every user who had it mounted. Fixes #46 Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Contributor
Author
|
/compile |
elzody
approved these changes
Jul 3, 2026
moodyjmz
force-pushed
the
fix/mine-filter-external-storage-owner
branch
from
e1c3844 to
567a024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External storage mounts (SMB, local, etc.) report the browsing user as
owner-idregardless of real ownership — most backends'getOwner()defaults to whoever is currently browsing when there is no single real owner. The overview's "Mine" filter only excludedgroup/sharedmount-types, so files on a shared external mount showed up as "Mine" for every user who had it mounted.This excludes
externalandexternal-session(session-credential mounts) from "Mine", alongside the existinggroup/shared. External files remain visible under the "All" filter —nc:mount-typecannot distinguish a personal external mount from a shared system one (both reportexternal), so the trade-off is to keep them out of "Mine" rather than misattribute ownership.Fixes #46
Note for reviewers: this PR is source-only. The
npm-buildcheck will be red ("Please recompile and commit the assets") until someone runs/compileon the PR so thenextcloud-commandbot commits the rebuilt bundle. The second commit documents this workflow in the README.