Skip to content

Set INSTALL_INTERFACE to CMAKE_INSTALL_INCLUDEDIR#1177

Merged
redboltz merged 1 commit into
msgpack:c_masterfrom
opoplawski:interface
Jun 9, 2026
Merged

Set INSTALL_INTERFACE to CMAKE_INSTALL_INCLUDEDIR#1177
redboltz merged 1 commit into
msgpack:c_masterfrom
opoplawski:interface

Conversation

@opoplawski

Copy link
Copy Markdown

While packaging msgpack-c for Fedora, I needed to install into /usr/include/msgpack-c to avoid conflicting with the msgpack C++ package. But then packages that used it would not look in the correct location for the msgpack.h file. This fixes that issue.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.35%. Comparing base (0299d94) to head (def509f).
⚠️ Report is 7 commits behind head on c_master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           c_master    #1177      +/-   ##
============================================
- Coverage     55.98%   55.35%   -0.64%     
============================================
  Files            10       10              
  Lines          1152     1120      -32     
  Branches        127      127              
============================================
- Hits            645      620      -25     
+ Misses          507      500       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redboltz

redboltz commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@opoplawski Thank you for sending the PR. Merged.

@redboltz redboltz merged commit da2b029 into msgpack:c_master Jun 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants