Remove dependency on memoffset for target_os = "windows"#361
Open
syberant wants to merge 1 commit into
Open
Conversation
`memoffset::offset_of!` was stabilised as `core::mem::offset_of!` in rust 1.77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for firefox!
I'm going down the list of reverse dependencies on
memoffset.This PR aims to remove the
memoffsetcrate from your dependencies.core::mem::offset_ofwas stabilised in rustc 1.77.The
memoffsetcrate 0.9.1 says thatI consider it very unlikely (see here) for any usage of the
offset_of!macro to break but please check anyway.I hope we can all enjoy the benefits of one less dependency :)
Your MSRV is unclear to me but this implies it's currently 1.90, maybe set it in
Cargo.toml?If that is correct this comment can also be followed up on.