refactor(helm): pass chart path to helm instead of cd-ing into it#105
Closed
rguichard wants to merge 1 commit into
Closed
Conversation
process_chart() changed directory into each chart to run `helm dependency update` / `helm template .` and then cd-ed back. Pass the chart path directly (`helm dependency update <path>`, `helm template <path>`) so no working-directory juggling is needed. The temp output paths are absolute (mktemp), so output is unaffected. INITIAL_DIR is removed as it is no longer referenced. No behaviour change. Addresses Aikido finding on validate-helm-charts.sh:110. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an Aikido finding on PR #90 (
validate-helm-charts.sh:110).process_chart()changed directory into each chart to runhelm dependency update/helm template .then cd-ed back. Pass the chart path directly (helm dependency update <path>,helm template <path>); temp output paths are absolute so output is unaffected.INITIAL_DIRis removed as it is no longer referenced. No behaviour change.🤖 Generated with Claude Code