Fix Sub::Defer but without the sub names#8
Open
oschwald wants to merge 2 commits into
Open
Conversation
…4, RT#120129)" This reverts commit c8f752e.
This is to maintain compatibility with modules that declare types but never use them. In 0.49, this could cause an exception if Sub::Defer::undefer_all was called.
Author
|
Ping. @autarch, any thoughts on this? See moose/MooseX-Types-LoadableClass#3 also. |
Member
|
I don't really have any thoughts. I'm not sure what's up with LoadableClass. I'm not using MX-Types in new code myself. |
Author
|
The PR I linked to fixed the particular issue in LoadableClass, which was declaring a type that was never actually defined. It instead replaced the declared version with the |
Author
|
Is there any chance this could get reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #7 but with the commit for the sub names dropped. That commit causes test failures depending on load order.