Fix DataFrame.applymap deprecation in CSIIndex._parse_excel#2270
Open
Whning0513 wants to merge 1 commit into
Open
Fix DataFrame.applymap deprecation in CSIIndex._parse_excel#2270Whning0513 wants to merge 1 commit into
Whning0513 wants to merge 1 commit into
Conversation
Replace with . DataFrame.applymap() was removed in pandas 2.2.0 (replaced by DataFrame.map() since pandas 1.4.0). This call in CSIIndex._parse_excel at line 174 would raise AttributeError on pandas >= 2.2.0 when processing index constituent changes from Excel files. Note: _parse_table at line 197 and get_new_companies at line 321 already use .map(), so this brings _parse_excel in line with the rest of the collector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DataFrame.applymap deprecation in CSIIndex._parse_excel