Copilot instructions + test filtering fix#1587
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Copilot/onboarding documentation (including host-layer guidance and CLI build/test recipes) and updates the xUnit dependency-based test orderer so filtered test runs no longer silently result in “no tests matched”.
Changes:
- Fix
DependsOnTestordering so missing dependencies (e.g., due todotnet test --filter) don’t cause dependent tests to be removed; instead a warning is logged. - Add xUnit diagnostic logging support to the test orderer (via
IMessageSinkwhen available). - Add Copilot instructions + several repo docs/READMEs, and include them as Solution Items.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/DebuggerTesting/Ordering/DependencyTestOrderer.cs | Adds diagnostic sink support and routes orderer diagnostics into xUnit output. |
| test/DebuggerTesting/Ordering/DependencyOrderer.cs | Changes dependency handling to ignore missing dependencies (filter-friendly) and adds overridable diagnostic logging hook. |
| src/MIDebugEngine.sln | Adds .github/docs Solution Items and updates solution header metadata. |
| src/DebugEngineHost/README.md | Documents the VS-host implementation role and contribution rules. |
| src/DebugEngineHost.VSCode/README.md | Documents the VS Code/OpenDebugAD7 host implementation role and contribution rules. |
| src/DebugEngineHost.Stub/README.md | Documents the contract/reference-assembly nature of the Stub project. |
| docs/Architecture-for-AI.md | Adds an AI-focused architecture/layering overview. |
| docs/Building-outside-of-VS-for-AI.md | Adds CLI build instructions for Windows and Unix/macOS paths. |
| docs/CodingStandards-CSharp-for-AI.md | Adds a summary of key C# conventions (anchored on .editorconfig). |
| docs/DebugEngineHost-for-AI.md | Adds detailed host-contract/implementation rules and map of host types. |
| docs/RunningUnitTests-outside-of-VS-for-AI.md | Adds CLI instructions for running managed unit tests. |
| docs/RunningCppTests-outside-of-VS-for-AI.md | Adds CLI instructions for running/diagnosing CppTests and explains the dependency/filtering quirk. |
| .github/copilot-instructions.md | Adds Copilot instruction entrypoint linking to the new docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR: - Adds copilot-instructions.md with links to documentation - Adds a READMD.md to the various DebugEngineHost implementations to make that more clear - Fixes a bug with how `DependsOnTest` works which made it so that any test with that attribute couldn't be run with a test filter
WardenGnaw
requested changes
Jun 18, 2026
WardenGnaw
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
DependsOnTestworks which made it so that any test with that attribute couldn't be run with a test filter