[HLSL] Preserve coherence qualifiers on resource flat-conversions#8583
Open
llvm-beanz wants to merge 1 commit into
Open
[HLSL] Preserve coherence qualifiers on resource flat-conversions#8583llvm-beanz wants to merge 1 commit into
llvm-beanz wants to merge 1 commit into
Conversation
PerformHLSLConversion forced the ICK_Flat_Conversion cast target to the structural/unqualified type, discarding the 'globallycoherent' (and 'reordercoherent') AttributedType. As a result, the converted expression's type no longer reflected the coherence of its destination, forcing consumers to reconstruct that information from declarations. Re-apply the coherence AttributedType to the flat-conversion result when the target is a resource type, so the converted expression's type carries the coherence of its destination (e.g. a ResourceDescriptorHeap[] access used to initialize a 'globallycoherent' resource).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PerformHLSLConversion forced the ICK_Flat_Conversion cast target to the structural/unqualified type, discarding the 'globallycoherent' (and 'reordercoherent') AttributedType. As a result, the converted expression's
type no longer reflected the coherence of its destination, forcing consumers
to reconstruct that information from declarations.
Re-apply the coherence AttributedType to the flat-conversion result when the
target is a resource type, so the converted expression's type carries the
coherence of its destination (e.g. a ResourceDescriptorHeap[] access used to
initialize a 'globallycoherent' resource).
Assisted by Claude Opus 4.8