Skip to content

add RoomID to switches and machines#651

Merged
mwennrich merged 12 commits into
masterfrom
add-room-label
Jul 14, 2026
Merged

add RoomID to switches and machines#651
mwennrich merged 12 commits into
masterfrom
add-room-label

Conversation

@mwennrich

@mwennrich mwennrich commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Currently, when switches in a partition are located in different rooms, there is no way to distinguish between machines in separate rooms—for example, for Kubernetes anti-affinity rules. This PR introduces a machine-room tag/label for each machine, enabling the use of such labels in anti-affinity configurations."

TODO:

  • tested in test
  • adding roomID to existing machines

Depends on: metal-stack/metal-lib#209

Used AI-Tools ✨

FITS/Kiero-Thinking (GLM 4.7)

@metal-robot metal-robot Bot added the area: control-plane Affects the metal-stack control-plane area. label Jun 12, 2026
@mwennrich mwennrich changed the title Add room label add RoomID to switches and machines Jun 12, 2026
@mwennrich
mwennrich marked this pull request as ready for review June 24, 2026 05:42
@mwennrich
mwennrich requested a review from a team as a code owner June 24, 2026 05:42
@mwennrich
mwennrich requested review from Gerrit91 and removed request for Gerrit91 June 24, 2026 05:42

@majst01 majst01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gerrit91 should also have a look

@mwennrich
mwennrich merged commit 3c62f12 into master Jul 14, 2026
2 checks passed
@majst01

majst01 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

can you please retrofit these changes into

in this order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: control-plane Affects the metal-stack control-plane area.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants