Fix issues with lfs and composer auth#41
Open
chippison wants to merge 2 commits into
Open
Conversation
sgiehl
reviewed
Jun 29, 2026
| # Plugin builds only compare the plugin's own screenshots, so skip Matomo | ||
| # core's screenshots (~124MB) and scope the plugin's pull to its UI dir. | ||
| cd $WORKSPACE/matomo/plugins/$PLUGIN_NAME | ||
| git lfs pull --include="tests/UI/expected-screenshots/*" --exclude= |
Member
There was a problem hiding this comment.
some plugins might also use "tests/UI/expected-ui-screenshots/*"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue 1:
We initially had an issue with lfs failing because we were pulling all our screenshot LFS for every job we did. This made us encounter our LFS limit.
We have added a fix in core so that we only pull the plugin's LFS screenshot on the job its doing it on. We just want premium plugins to get this fix as well.
Issue 2
We also have an issue where our 8.2 and 8.5 System and Integration tests failing. This was actually caused by compose
Root cause
For PHP 8.x,
scripts/bash/prepare.shbumps phpunit viacomposer remove --dev phpunit/phpunitthencomposer require --dev phpunit/phpunit ~9.3 ....The
requirere-resolves the tree, which makes composer fetch commitmetadata for
dev-master-pinned deps (e.g.matomo-org/matomo-coding-standards)from
api.github.com. Those requests were unauthenticated, so GitHubreturned an HTTP 429 anti-scraping throttle:
We have made the fix here to add in our github token when we do composer require.
Checklist
Review