Feature/update release v1.3.1#9256
Open
sonct1 wants to merge 7 commits into
Open
Conversation
- Add KeycloakOAuthProvider with full OIDC flow support - Add error codes (5113, 5124) and OAuth adapter integration - Add App and Space OAuth endpoints with URL routing - Update account model and migration for keycloak provider - Add instance config variables and API support - Add frontend types and OAuth hooks for web/space/admin - Add admin config UI (toggle, form, routes) - Add Keycloak logo assets for all three apps - Add comprehensive unit tests for provider (16 tests, all passing)
- Add missing keycloak entry in availableAuthenticationModes array - Add keycloak service to docker-compose-local.yml - Add keycloak local dev guide
Add comprehensive specification for unlocking premium features in the Plane Community Edition while maintaining upstream compatibility. Key findings from codebase analysis: Architecture: - All premium UI is gated via @/plane-web/* path alias resolving to ce/ - CE stubs return <></> or upgrade banners for paid features - Backend has ZERO edition enforcement — all API endpoints work regardless of Instance.edition value - vite-tsconfig-paths supports array fallback in paths config Strategy: Sparse overlay directory (ee-local/) - Single tsconfig.json change: add ee-local/* as first fallback - Override only specific CE stubs, everything else falls through - Near-zero merge conflict risk on upstream pulls - TypeScript type-checking detects interface drift automatically Feature classification: - Tier 0 (config only): OIDC/Keycloak SSO, Wiki, Real-time Collab, Page Versions — already fully implemented, just need env vars - Tier 1 (overlay unlock): Active Cycles, Project Publish, Estimates, Issue Relations — backend + core frontend exist, CE stubs block them - Tier 2 (needs new code): Gantt Dependency Paths, Bulk Ops, View Publish — backend exists but frontend needs significant implementation - Tier 3 (not in repo): Time Tracking, Epics, Automations, RBAC, SAML, LDAP, PQL, etc. — no code exists, would require full development Includes phased implementation plan, upstream pull workflow, and overlay directory structure.
sonct1
requested review from
dheeru0198,
pablohashescobar and
sriramveeraghanta
as code owners
|
Nguyễn Trọng Cường seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References