Skip to content

lock size on tenant selection so the home settings does not overflow#1926

Open
Mynster9361 wants to merge 4 commits into
maester365:mainfrom
Mynster9361:fix/multitenant-sidebar
Open

lock size on tenant selection so the home settings does not overflow#1926
Mynster9361 wants to merge 4 commits into
maester365:mainfrom
Mynster9361:fix/multitenant-sidebar

Conversation

@Mynster9361

@Mynster9361 Mynster9361 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

📑 Description

This fixes issue #1903 where if you have too many tenants configured for ytour report the Home and other settings disappear

Introduces a fixed height for the sidebar for tenants and a scroll bar
maester multitenant

Closes #1903

✅ Checks

  • My pull request adheres to the code style of this project.
  • My code requires changes to the documentation.
  • I have updated the documentation as required.
  • The build and unit tests pass after running /powershell/tests/pester.ps1 locally.

ℹ️ Additional Information


How to Contribute

🏗️ Read our full contributing guide for the Maester project.
🧪 We also have additional instructions and a checklist for creating tests.

Join us at the Maester repository discussions or Entra Discord for more help and conversations!
While you wait for a review, why not spread some Maester love on social media? Thank you! 💖

Summary by CodeRabbit

  • Bug Fixes
    • Improved sidebar scrolling for tenant lists, including expanded and collapsed views.
    • Constrained sidebar and tenant list heights to keep navigation content accessible and prevent layout overflow.

@Mynster9361 Mynster9361 requested a review from a team as a code owner July 10, 2026 09:59
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The head commit changed during the review from ec8ef1c to df13377.

📝 Walkthrough

Walkthrough

The Sidebar now constrains its height and adds vertically scrollable tenant lists with separate limits for expanded and collapsed layouts. The default setIsCollapsed callback formatting is also adjusted without changing behavior.

Changes

Sidebar layout

Layer / File(s) Summary
Tenant selector layout
report/src/components/Sidebar.tsx
The Sidebar root adds max-h-screen; expanded and collapsed tenant selectors add non-shrinking wrappers, bounded heights, vertical scrolling, padding, and spacing classes. The default setIsCollapsed callback formatting is updated without semantic change.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The sidebar height and tenant list scrolling changes address the reported Home/View overflow issue in #1903.
Out of Scope Changes check ✅ Passed The changes stay focused on the sidebar overflow fix and a harmless context cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title is clearly related to the main change and summarizes the sidebar tenant-sizing fix.
Description check ✅ Passed The description follows the template, includes the fix summary, issue closure, and checklist items.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@Mynster9361

Copy link
Copy Markdown
Contributor Author

I do not believe these two has anything to do with my changes
image

both relate to the ReportTemplate.html which is autogenerated on npm build
my changes only touches the sidebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🪲 Home\View area on HTML report becomes inaccessible when Tenant list is large

1 participant