Add sub-signature to enable matching of gcc vs clang#22
Merged
Conversation
| self.target = target | ||
| self.src_file = "" | ||
| self.location = "" | ||
| self.position = "" |
Contributor
There was a problem hiding this comment.
location and position is very confusing imho, if we could modify them to something like line_no and column_no I think it would be better
Collaborator
Author
There was a problem hiding this comment.
I thought about it too, but left location like that, because for some cases location is an address. What we could do is to maintain locationfor those cases and then have line_no and pos for the ones we are dealing with here.
Collaborator
Author
|
@helen-fornazier @tales-aparecida thanks for the python tips :) |
added 3 commits
May 27, 2025 15:41
Leave them to be printed only by full json option. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
gcc and clang are reporting different line position for the same code error. If we want to compare logs from both compilers we have to make the split, so we can compare the line of the error as well. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
We need a way to match issues reported both by gcc and clang, so creating a subsignature that exclude line position and error summary allow us to have the same `signature_loc` for both. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
signature_locwith a signature that exclude the error summary message and the line position of the error, so we could generate the same hash for errors both from gcc and clang.Related to #11