Skip to content

Harden audio pipelines and reduce VibeVoice memory#33

Merged
jvogan merged 1 commit into
mainfrom
codex/bounded-audio-vibevoice-memory
Jul 18, 2026
Merged

Harden audio pipelines and reduce VibeVoice memory#33
jvogan merged 1 commit into
mainfrom
codex/bounded-audio-vibevoice-memory

Conversation

@jvogan

@jvogan jvogan commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • bound decoded audio size, format, playback queue, and export work
  • harden file destinations and preserve existing outputs on failed exports
  • reduce VibeVoice conditioning and scheduler memory without changing numerical behavior
  • add focused admission, resource-bound, destination-safety, and equivalence tests

Validation

  • public repository audit, secret scan, and history scan
  • full public validation gate
  • 28 focused audio and VibeVoice tests
  • 54 macOS application tests

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1cb93fa3aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +421 to +424
guard Self.validatedConcatenatedPCMByteCount(
channelSampleCounts: channelCapacities
) != nil else {
return nil

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid rejecting long concatenated exports

When project export uses concatenated mode, ProjectAudioExportCoordinator still calls concatenatedBuffer before audioPipeline.export (apps/ValarTTSMac/Sources/ValarTTSMacApp/Projects/ProjectAudioExportCoordinator.swift:136-148). This new 64 MiB check makes concatenate return nil for otherwise-compatible audio over about 11.6 minutes of mono 24 kHz float32 audio, or about 5.8 minutes stereo, surfacing as ProjectAudioExportError.incompatibleBuffers before WAV/M4A export can run. Either route those exports through a streaming writer before applying this cap or keep the full-buffer path available for long projects.

Useful? React with 👍 / 👎.

@jvogan
jvogan merged commit 5bc5915 into main Jul 18, 2026
4 checks passed
@jvogan
jvogan deleted the codex/bounded-audio-vibevoice-memory branch July 18, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant