Skip to content

Sync public project tooling and safety updates#32

Merged
jvogan merged 1 commit into
mainfrom
codex/public-repo-sync-2026-07-17
Jul 18, 2026
Merged

Sync public project tooling and safety updates#32
jvogan merged 1 commit into
mainfrom
codex/public-repo-sync-2026-07-17

Conversation

@jvogan

@jvogan jvogan commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • add project linting, voice-bible analysis, and portable export-pack manifests
  • add bounded OGG input handling and clearer model-download progress and failures
  • align public model licensing, guidance, and long-form documentation
  • strengthen public-repository disclosure and secret validation

Safety

  • current-tree, include-ignored secret, and Git-history scans pass
  • stale publication-process documents were removed
  • no private paths, credentials, or internal working material are included

Validation

  • make validate-public
  • ModelKit: 110 tests
  • Persistence: 80 tests
  • Core: 195 tests
  • CLI: 59 tests
  • daemon and CLI builds
  • bridge dependency audit and TypeScript typecheck

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 248ee187dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +230 to +232
let declaredByName = Dictionary(
uniqueKeysWithValues: speakers.map { ($0.name.lowercased(), $0) }
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle duplicate speaker profile names

When a project contains two speaker profiles with the same name (including case-only variants like Narrator and narrator), this Dictionary(uniqueKeysWithValues:) call traps at runtime with a duplicate-key precondition failure. The app/store paths allow multiple ProjectSpeakerRecords distinguished only by UUID, so projects lint and projects export-pack can crash on valid existing project data instead of producing a voice bible; group or otherwise disambiguate duplicate names before building the lookup.

Useful? React with 👍 / 👎.

@jvogan
jvogan merged commit 7af977d into main Jul 18, 2026
4 checks passed
@jvogan
jvogan deleted the codex/public-repo-sync-2026-07-17 branch July 18, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant