fix(windows): reap republished daemons during nuke#657
Open
nsxdavid wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 989f8eaf45
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
989f8ea to
18d898d
Compare
18d898d to
bc4f46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli-daemon.pipeafter the visible owner exits are also terminated.cli-daemon.piperecords under{home}/.codedb/projectsand retain process-image verification before termination.Issue
No standalone issue exists; this addresses the post-merge Codex review note about multiple retry-mode Windows daemons.
Validation
zig build --global-cache-dir .zig-global-cache test-mcp -Dtest-filter="nuke" --summary all- 7/7 tests passedzig build --global-cache-dir .zig-global-cache test --summary all- 869/873 tests passed (4 skipped)zig build --global-cache-dir .zig-global-cache --summary all- 3/3 steps succeededPYTHONUTF8=1; python scripts/e2e_mcp_test.py --binary zig-out/bin/codedb.exe --project .- 20/20 passed on Windows using a repo-local test homegit diff --check- passed