Skip to content

fix(windows): reap republished daemons during nuke#657

Open
nsxdavid wants to merge 1 commit into
justrach:release/0.2.5828from
nsxdavid:fix/windows-nuke-reap-daemons
Open

fix(windows): reap republished daemons during nuke#657
nsxdavid wants to merge 1 commit into
justrach:release/0.2.5828from
nsxdavid:fix/windows-nuke-reap-daemons

Conversation

@nsxdavid

@nsxdavid nsxdavid commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Follow-up to merged Add Windows warm daemon IPC #641 for the Windows nuke cleanup path.
  • Reap metadata-discovered Windows warm daemons in bounded passes so retry-mode serve/mcp daemons that republish cli-daemon.pipe after the visible owner exits are also terminated.
  • Keep cleanup scoped to cli-daemon.pipe records under {home}/.codedb/projects and retain process-image verification before termination.

Issue

No standalone issue exists; this addresses the post-merge Codex review note about multiple retry-mode Windows daemons.

Validation

  • zig build --global-cache-dir .zig-global-cache test-mcp -Dtest-filter="nuke" --summary all - 7/7 tests passed
  • zig build --global-cache-dir .zig-global-cache test --summary all - 869/873 tests passed (4 skipped)
  • zig build --global-cache-dir .zig-global-cache --summary all - 3/3 steps succeeded
  • PYTHONUTF8=1; python scripts/e2e_mcp_test.py --binary zig-out/bin/codedb.exe --project . - 20/20 passed on Windows using a repo-local test home
  • git diff --check - passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 989f8eaf45

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/nuke.zig Outdated
@nsxdavid nsxdavid force-pushed the fix/windows-nuke-reap-daemons branch from 989f8ea to 18d898d Compare July 4, 2026 23:35
@nsxdavid nsxdavid force-pushed the fix/windows-nuke-reap-daemons branch from 18d898d to bc4f46a Compare July 4, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant