Scope clearToasts to the dialog being closed#3414
Open
Salvialf wants to merge 1 commit into
Open
Conversation
zoic21
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
jeeDialog'sclose()unconditionally callsclearToasts(), which removes every toast currently displayed on the page, not just the ones related to the dialog being closed. Since there is a single shared toast container reused across the whole page, any toast shown right before closing a dialog (a common pattern: perform an action, then close the dialog) gets wiped out immediately.Plugins have been working around this by manually closing the dialog before showing the success toast instead of the more natural order (see calendar/event.edit.js or ocpp/authorisations.js as examples).
Fix
clearToasts()now accepts an optional scope element. When provided, it only removes the toast container if it is currently a descendant of that scope, leaving toasts attached elsewhere (typicallydocument.body) untouched. The main dialog'sclose()now passes itself as the scope, so it only cleans up toasts explicitly attached to it viaattachTo.All other existing call sites (page navigation, notification center, legacy jQuery shim) keep clearing every toast since they call
clearToasts()without a scope, so their behavior is unchanged.