Fix setTags() reference error in jeeApi & plan3d#3408
Open
Salvialf wants to merge 3 commits into
Open
Conversation
Salvialf
added
the
changelog-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Following PR #3407, two additional calls to
scenarioExpression::setTags()were found where a function result was passed directly as the first argument, which is declared by reference (&$_expression). This triggers a PHP "Only variables can be passed by reference" notice.Changes
core/api/jeeApi.php: remove thetrim()wrapper around$valuebefore passing it tosetTags(the function already trims its argument internally on line 1263)core/class/plan3d.class.php: store the result ofgetConfiguration()in a local variable before passing it tosetTags